Uninstall gem 'forest_liana'/Forest Admin#327
Uninstall gem 'forest_liana'/Forest Admin#327kirbyfern wants to merge 2 commits intoOperationCode:masterfrom kirbyfern:origin/issue#323
Conversation
hpjaj
left a comment
hpjaj
left a comment
There was a problem hiding this comment.
There are changes that are in
config/secrets.yml.env
that need to be removed, as well.
| airtable (0.0.9) | ||
| httparty | ||
| arel (7.1.4) | ||
| arel-helpers (2.6.1) |
There was a problem hiding this comment.
Try re-running make bundle to see if that resolves your gemfile.lock issues.
If not, try to rebase on master, then make bundle.
There was a problem hiding this comment.
hmm it doesn't resolve the conflict issues let me just try to make another branch and do all the proper changes together
| @@ -1,2 +0,0 @@ | |||
| ForestLiana.env_secret = Rails.application.secrets.forest_env_secret | |||
There was a problem hiding this comment.
This file needs to be deleted, not just the contents removed. I can't tell if it has been removed, or just emptied out.
There was a problem hiding this comment.
ok I did not see this
|
In addition to the changes in here, can you pls change the PR's title to something closer to the title of the associated issue. We want these PR titles to summarize all of the changes in the PR. Moreover, when you look back and read through the list of closed PR's, you should be able to tell exactly what PR is doing, from its title. This is very helpful later on, when you are trying to debug an issue, or determine how to approach an upcoming feature, etc. |
|
I made another pr |
3 participants
Description of changes
make bundleto update dependenciesIssue Resolved
Fixes #323 reference #283